Open shelbysawyer opened 1 year ago
Actually going to assign this to @KellyMWhitehead. He's currently leading desktop QGIS plugin development
I think this is related to:
Just had a quick chat with @KellyMWhitehead
I thought hitting "update resources" in the QRV toolbar updates the XML in that app data / roaming folder that "Find Resources Folder" brings you to.. but I noticed that it doesn't seem to be updating to match what's on Git. I think that might be part of the problem I'm having
I presume the update resources will only update based on the master
branch. In other words, pull requests need to be fully merged.
Are you sure the changes you want are on the master branch?
Yes, the latest updates from this morning were merged to the master branch and I see those latest changes to the V1 BL reflected here. Kelly said he was seeing this problem too (where 'Update Resources' doesn't update the XML in the local resources folder).
There can be a slight lag at GitHub between the branch getting updated and the content being available at the specified URL.
The code to update the resources has not changed in a long time. If there are no bugs throwing in the code then I think it might just be GitHub delay in serving the latest version of the file in their content delivery system. (The lag is somewhat intentional as they don't really want people using their systems to serve high traffic content in this way.)
@MattReimer might I be on the right track?
You could be but my spidey sense is tingling a bit since this issue has cropped up multiple times that there is something in QRave that we are not try-catching. No matter what state the business logic is in you should not be seeing this error.
Certainly there is a delay when the pull request goes through but that shouldn't cause a QRave error
BTW: If you want an indication of when the branch is ready to use you can actually see it on the Repo's main page
I tried to open this project in QRV to test the V2 business logic, and got this error:
@MattReimer @philipbaileynar @jtgilbert just putting this on your radar. Could it just be a problem on my end?