Hydro Outputs GeoPackage Improvements - Githubissues

Riverscapes / riverscapes-tools

Open-source Python 3.0 tools for the Riverscapes organization

https://tools.riverscapes.net/

GNU General Public License v3.0

11 stars 11 forks source link

Hydro Outputs GeoPackage Improvements #998

Closed philipbaileynar closed 2 months ago

philipbaileynar commented 2 months ago

Assigning this to @r-k-g ... but I can take it on if you'r uncomfortable with the DDL required. I think the changes required are in this file:

packages/hydro/database/hydro_schema.sql

DGOAttributes
- Missing index
  - FCode
  - (level_path, sequence)
DGOGeometry
- Missing Index
  - FCode
  - (level_path, seg_distance
Ecoregions
- EcoregionID seems to be indexed twice? PK and also manual index? Drop the latter.
- Drop index on Name? Do we ever rely on SQL WHERE clauses that use Name?
IGOAttributes
- Missing Index
  - FCode
  - (level_path, sequence)
IGOGeometries
- Missing Index
  - FCode
  - (level_path, sequence)

General Issues

I don't think the keyword UNIQUE is needed wherever PRIMARY KEY appears. PK already ensures uniqueness and I think that this is causing redundant indexes to be created.

philipbaileynar commented 2 months ago

These changes were implemented on 28 Aug... forgot to tag issue.