search

Rizen54 / richweather

A simple python CLI tool to fetch weather of any given city.
MIT License
38 stars 1 forks source link

make it a real python module #1

Closed oblivikun closed 2 months ago

oblivikun commented 2 months ago

This is something with a couple stuff you might want to change in setup.py, you also might want to change the directory structure. but this makes it a real python module that you can upload to pypi later.

Rizen54 commented 2 months ago

Thanks for the work you did but i already use data from python-weather which in itself is an API wrapper so i dont think this will be a good idea. So for now im closing the PR, if you have any other suggestions or if you can help me turn into a linux pkg please let me know. You could however fork it and make your own program using my code, i'd encourage it.

Rizen54 commented 2 months ago

you removed the if name == "main" part, how will people now run it as a terminal command?

oblivikun commented 2 months ago

by using the entry point defined in setup.py. you run it by doing pip install . and then just running the built richeweather. You could also do if name name == "main" then call the main function

Rizen54 commented 2 months ago

Alright then I'll change the author name and in the setup file, add the if name main thing and merge it. Tysm for the contribution!

Rizen54 commented 2 months ago

Thanks a lot for contributing to richweather! I'm very happy to see your changes working perfectly.