search

Rizen54 / richweather

A simple python CLI tool to fetch weather of any given city.
MIT License
38 stars 1 forks source link

Config file stuff #3

Closed oblivikun closed 1 month ago

oblivikun commented 2 months ago

This code is pretty mysterious, i think it works because i tested it with 10 diffirent cities and the formatting wasnt weird. but its kind of a mess because i was deleting stuff and forgot to cleanup

oblivikun commented 2 months ago

because the previous set of unicodes didnt render well with my fonts

oblivikun commented 2 months ago

and it got annoying to look at

Heinrich-XIAO commented 2 months ago

ok, well the new ones don't render well with my font image old one on the irhgt and new one on the left

oblivikun commented 2 months ago

This is not as dynamic as what we have now, theoretically we could use the thing with the moon_len and weather_len here but that wouldnt look very nice and take up alot of lines.

oblivikun commented 2 months ago

the only diffirence is that you have some pretty generous maximum values

oblivikun commented 2 months ago

The cool fancy thing didnt work because of that border inbetween the left and right. i think it would be pretty hard to align that correctly 100% of the time

Rizen54 commented 1 month ago

There you go. That's the reason I wasn't willing to work on this :p well keep on working ig haha

oblivikun commented 1 month ago

Right now it is aligned correctly 100% of the time but i dont like how its done

oblivikun commented 1 month ago

There you go. That's the reason I wasn't willing to work on this :p well keep on working ig haha

I did it

oblivikun commented 1 month ago

it works

oblivikun commented 1 month ago

if the unicode looks weird on your computer, just change it.

oblivikun commented 1 month ago

with the fancy stuff btw

Rizen54 commented 1 month ago

Ig we should find some better way to implement the symbols, something that's inclusive to most fonts and terminals

oblivikun commented 1 month ago

a good way would be to find some more common unicode symbols

Rizen54 commented 1 month ago

Alright. Did a lot of improvements, dw the paddings and borders work good. Also i was having some issue with the yaml. @oblivikun please provide some default configuration for the yaml file in the README.md or add it as a file in the repo and in the installation copy it to .config/richweather/

Rizen54 commented 1 month ago

Do the yaml config thing in a new PR, imma merge this one. I'll also add unicodes for most symbols later on.

Rizen54 commented 1 month ago

Also review my changes before i merge

Rizen54 commented 1 month ago

@oblivikun i request you to join my dc server so that we can have better talks

oblivikun commented 1 month ago

I dont use discord, but you can talk on https://tweetor.org

Rizen54 commented 1 month ago

Also review my changes before i merge

Everything good? @oblivikun

oblivikun commented 1 month ago

a little formatting stuff

oblivikun commented 1 month ago

should be fine to merge now