[Issue] Colonial competitor never spawn and research mandate faction never transform

[WilliamSchmitt120]

Mod Name:

Vayra Merged

Mod Version:

3.3.10

What did you expect to happen?

Colonial Competitor should spawn after some time or when the player found a colony.

What actually happened?

Colonial Competitor never spawn no matter what time passed. I tried using only vayrasector and magiclib to test if it was not another mod.

Steps to Reproduce:

1. Start a vanilla game of starsector with only VayraSector, MagicLib and speedUp/Consol Commands for conveniance.
2. Wait for time passes (or modify the setting files to spawn colonial competitor early or use Vayra Debug).
3. Nothing happen.

Screenshots/Logs:

I found this log when trying to search in the starsector log files :

39087 [Thread-3] INFO data.scripts.campaign.colonies.VayraColonialManager - Assembling Ashen Keepers colonial expedition at Asher, target: Unhcegila 39087 [Thread-3] INFO data.scripts.campaign.colonies.VayraColonialManager - Expedition picked Unhcegila in Kigatilik Star System as a target, but that causes an error -- i thought i fixed this...

They are many other similar line for every colony competitor faction in the logs so this may be the problem.

Additional info:

I've also found that even when I forced spawn the factions with nexerelin and consol commands, the research mandate never transform into the Aleph Ascendancy even after I give them the entire sector and add alphacore on every planet and industries. I think it may be related to this problem so I'm not making an another issue for now. Maybe I should ?

Excuse me if I made spelling mistakes, English is not my primary language.

[RkShaRkz]

We can look at this further after the next version drops @WilliamSchmitt120 , feel free to ping me on discord so i can send you test builds to pinpoint what the problem is.

for what it's worth, it's coming from this bit of VayraColonialManager

                try {
                    VayraColonialExpeditionIntel expedition = new VayraColonialExpeditionIntel(colonyFaction, source, target, fleetPoints);
                    planetsTargetedForColonies.add(target);
                    spamLog("VayraColonialManager::advance()\tUPGRADE SECTION\tadded planet as target for colony\ttarget name: "+target.getName()+", target star system: "+target.getStarSystem());
                } catch (NullPointerException ex) {
                    log.info(String.format("Expedition picked %s in %s as a target, but that causes an error -- i thought i fixed this...", target.getName(), target.getStarSystem()));
                }

[RkShaRkz]

@WilliamSchmitt120 can you test this build? https://ufile.io/ie0swkbc

this is actually the fix for issue #44 but... i mean, just so we know it's completely unrelated to that problem. Since it kinda sounds like it's related, but then diverges with the "research mandate never transforms".

[WilliamSchmitt120]

I will test it this week end.

[RkShaRkz]

I will test it this week end.

any results?

[RkShaRkz]

@WilliamSchmitt120 any updates?

[RkShaRkz]

@WilliamSchmitt120 well? did you give up on this? if you're willing, i can send you a pre-release (aka a release candidate) to verify if the issue is still present or not, so that we know what to do with it.