issues
search
Rm1509
/
array-models
1
stars
0
forks
source link
Ideas for improving `makeHelicoid.m`
#1
Open
NatalieZelenka
opened
1 year ago
NatalieZelenka
commented
1 year ago
[x] Make a separate script to test the make helicoid function
[x] move parameters like homefol that are currently commented out over there
[x] Make sure we don't have duplicate variables that refer to the same thing (e.g.
ar
and
AR
).
[x] Write some
docstrings
for the arguments of your function.
[x] Make smaller functions for bits of code with specific purposes and give them descriptive names.
[x] Have default values for things that aren't provided (maybe we might need to research how that looks exactly)
Rm1509
commented
1 year ago
[ ] use profiling on the matlab script
[ ] use profiling on the lumerical script
[ ] decide in what order to create / open / rotate the shapes (according to profiler)
[ ] allow different shapes to be made by calling their names
[ ] work out how best to run both pieces of code together - through cmd or through matlab (or python)?
[ ] design first tests and output plots
ar
andAR
).