search

Rmcrmc / parchment

Automatically exported from code.google.com/p/parchment
GNU General Public License v2.0
0 stars 0 forks source link

Android Browser crash upon game restore (URL storage) #140

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Play a game in parchment in the Android browser (curses or anything else is 
fine). Save. URL is changed per normal.
2. Reload the URL, or save a bookmark and load it, or however you do this.
3. Select the text input field of the Android browser and attempt to type.

Android will now crash. You can reproduce this in the Android Emulator, as well.

What is the expected output? What do you see instead?
I expect that restoring a saved game doesn't crash the browser.

What version of the product are you using? On what operating system?
Tip of the trunk of parchment, ui_bugfixes branch of my fork, etc.

Please provide any additional information below.
In order to determine whether this issue was related to the actual save/restore 
code, or whether it is related to the storage code, I implemented a different 
type of savegame storage (using persistJS: 
http://github.com/jeremybernstein/parchment/tree/persistjs). This works fine. 

I am 99% convinced that we're dealing with a WebKit bug in the Android 2.2 
browser -- these URL strings are over 3200 characters long. 

Editorially and perhaps irrelevantly, I find the persistJS solution 
(localStorage) much more elegant, since you can save and restore, list and 
delete different 'gamefiles' for a game, rather than dealing with ginormous
URLS. The only advantage of the URLs is that you can move them from one browser 
to another.

Original issue reported on code.google.com by jeremy.d...@googlemail.com on 4 Oct 2010 at 11:25

GoogleCodeExporter commented 8 years ago 
OK, I've done a bit more research and I think Dannii's right. The old input 
code does not result in a crash, whereas the input code at the tip of the trunk 
does. So there's something foul with the new input code wrt the Android 2.2 
browser.

Original comment by jeremy.d...@googlemail.com on 4 Oct 2010 at 11:41

GoogleCodeExporter commented 8 years ago 
This is the same as http://code.google.com/p/parchment/issues/detail?id=141

Original comment by jeremy.d...@googlemail.com on 4 Oct 2010 at 12:48

GoogleCodeExporter commented 8 years ago 
Issue 141 has been merged into this issue.

Original comment by curiousdannii on 4 Oct 2010 at 2:09