search

RnDity / NavigationFlowCoordinator

Basic implementation of coordinators pattern helping to deal with UINavigationController based flow.
MIT License
6 stars 4 forks source link

Added coordinator support for different navigation styles + update to Swift 4. #15

Closed sedwo closed 6 years ago

sedwo commented 6 years ago

Ready for review.

sedwo commented 6 years ago

Some more enhancements. Ready for review.

sedwo commented 6 years ago

I just pushed up:

Reverted to deployment target of iOS v9.1
+ added camel case to enum.
sedwo commented 6 years ago

Will you continue to investigate support for modal coordinators in your library? I really like some of the simplicity in your coordinator library compared to many others and believe it's an important feature to fulfill around navigation. Then afterwards we can get into other animation styles. (eg. fade, flip) ;)

rafalur commented 6 years ago

Glad to hear that you find the library useful.

I agree that support for modal coordinators is pretty important. However as you can see there are couple of problems with this and it's not that trivial to implement this. But yes, it's worth investigating and we have plans to do it but at the moment we are quite busy with other stuff and we can get back to it not sooner than within few weeks.

rafalur commented 6 years ago

@sedwo Could you revert this commit: "Added coordinator support for different navigation styles."? As we discussed there are still some problems with this functionality and we don't want to merge it until we are sure it works properly. Once reverted we would merge this PR.