search

RnDity / NavigationFlowCoordinator

Basic implementation of coordinators pattern helping to deal with UINavigationController based flow.
MIT License
6 stars 4 forks source link

Different navigation styles missing support for coordinators #16

Open sedwo opened 6 years ago

sedwo commented 6 years ago

Your design has a fixed navigation style presentMainViewController() { push(...) for all coordinators. And while you do have functions to present other viewControllers, they do not support being wrapped in the coordinator pattern.

I think you should extend coordinator support to cover all navigation styles (push and present with modals too).

sedwo commented 6 years ago

Here's my version on what I'm talking about. https://github.com/sedwo/NavigationFlowCoordinator/commit/d671d7b406144938a1360b18ffe4f70bb94414d7 I think it fulfills this library better now with a consistent coordinator pattern.

Let me know what you think.