search

Ro5bert / avra

Assembler for the Atmel AVR microcontroller family
GNU General Public License v2.0
156 stars 40 forks source link

Fix ifdef and ifndef #12

Closed Ro5bert closed 4 years ago

Ro5bert commented 4 years ago

Previously, future definitions affected ifdef and ifndef, breaking the following common pattern, for example: .ifndef xyz .define xyz ... .endif

Now, if a ifdef/ifndef condition fails in the first pass, it never succeeds in the second pass, and if it succeeds in the first pass, it always succeeds in the second pass.

ghost commented 4 years ago

@Ro5bert Thanks for the patch. It looks a bit deeper than I have motivation to review. Since I've added an AVR assembler in my Collapse OS project, I haven't been using AVRA, which explains why I lack motivation for this review.

Would you be interested in taking over maintainership of the project? I don't think it's a big responsibility because I don't think many people use it.

Ro5bert commented 4 years ago

I only just recently started using AVRA, but I would be happy to maintain it if you are no longer interested/don't have the time.

ghost commented 4 years ago

Alright, transferring repo.

ghost commented 4 years ago

You need to delete your fork before I can proceed.

Ro5bert commented 4 years ago

Ok, it has been deleted.