Ro5bert / avra

Assembler for the Atmel AVR microcontroller family
GNU General Public License v2.0
153 stars 39 forks source link

Definition of support levels. #35

Closed supakeen closed 3 years ago

supakeen commented 3 years ago

Let me preface this: there was absolutely no need to add this and it wasn't listed anywhere. It's something I might find to be useful while adding support for new devices and something to get to know the project, its style, and get into C again.

If there's too much to think about with a change like this (like when does a device transition from EXPERIMENTAL -> STABLE) then this PR can just be closed!

This PR allows tagging devices with a support level.

Ro5bert commented 3 years ago

I like the idea behind this, but I'm not sure tracking whether a device is experimental/stable in code is the best idea; usually this sort of thing would be handled with versioning. Also, since few people use AVRA, currently device support is added when a single user needs it. If a user submits a PR adding support for a device, I assume they tried it and it works for them. Beyond that, there's no way to tell how "stable" support for a device is (I certainly don't own most of the various AVR devices, so I can't usually test new device support myself, although I do always verify properties from datasheets). So (as you suggest) there wouldn't be a good time to move a device from experimental to stable. Hence, I'll close this for now.