RoBrit / Moo-Fluids

Mod for Minecraft that dynamically generates 'milkable' cows for various fluids
GNU General Public License v3.0
16 stars 18 forks source link

Timer resets when clicked with hand #18

Closed TheFjonG closed 8 years ago

TheFjonG commented 9 years ago

Can you change line 91 in https://github.com/TheRoBrit/Moo-Fluids/blob/master/src/main/java/com/robrit/moofluids/common/entity/EntityFluidCow.java to something that checks whether the held item is a fluid container or not? ;)... Please :)

TheFjonG commented 9 years ago

Line 91: if (getCurrentUseCooldown() == 0) {} to if (getCurrentUseCooldown() == 0 && FluidContainerRegistry.isEmptyContainer(currentItemStack)) {} ? :+1:

RoBrit commented 9 years ago

Good spot, your solution is an improvement to the logic but would still allow for fluid containers that could not viably be used (for that particular cow) to reset the timer. But I have found an appropriate way of fixing this.

Thanks for the report.