search

RoBrit / Moo-Fluids

Mod for Minecraft that dynamically generates 'milkable' cows for various fluids
GNU General Public License v3.0
16 stars 18 forks source link

[1.10.2] Hwyla support? #45

Closed DeadSix27 closed 6 years ago

DeadSix27 commented 7 years ago

Can you add support for Hwyla on 1.10.2? https://github.com/TehNut/HWYLA

image

RoBrit commented 7 years ago

I'll try add support for both Hwyla and One Probe. Support for Waila should already exist for 1.10.2. Unknown ETA but I'll close this issue and release a new update once it's done so keep an eye out.

brisingraerowing commented 7 years ago

Hwyla seems to use the exact same system as Waila, so I would think it should work out of the box. The Hwyla page even says it's compatible with all Waila plugins, so it not working here is odd.

DeadSix27 commented 7 years ago

@BrisingrAerowing It didn't when I opened the issue which is why I reported it.. Not sure if that is still the case now nor can I test it unfortunately.

EDIT: I mean look at the screenshot, it has newest Hwyla installed.. I don't see it working.

brisingraerowing commented 7 years ago

I took a look inside the Jar file from Curseforge, and there is a file from WAILA in there that seems to be interfering with the integration. I did a build from the repository (where the file doesn't exist), and that works with HWYLA perfectly fine.

DeadSix27 commented 7 years ago

@BrisingrAerowing ahh it ships with the library packaged in already? Interesting, good to know. When I get back on MC ill try it. (idk when tho, can be anywhere from days to months 🙃 )

brisingraerowing commented 7 years ago

@DeadSix27 Just a single file from Waila. I think there was a build derp that caused that file to be added.

If you open the Jar with 7-Zip (or some other archiver) you can delete the file, the path is com/robrit/moofluids/common/plugins/waila/WailaRegistrar.class. That should allow the mod to work correctly.

@TheRoBrit You might want to check that and upload a fixed build.

twizcraft commented 7 years ago

@BrisingrAerowing the deleting of the file still doesn't work thanks for trying to help.

Fundryi commented 7 years ago

We need that god damn HWYLA support xD!

Codystar44 commented 7 years ago

Just tested, not working with original waila either

ThexXTURBOXx commented 7 years ago

Well, the repo and the mod hasn't been updated since February. I don't know, if this is forbidden, but here is the newest version from the repo for 1.10.2: http://femtopedia.de/MooFluids-1.10.2-1.7.02.12b.jar This one adds Hwyla-Support (I don't know, if I have done everything correctly, so that WAILA is still supported). Anyway, Hwyla works and you should use Hwyla over WAILA, because ProfMobius stopped working on WAILA ;)

RoBrit commented 7 years ago

I do not support xxTURBOXx's version of the mod nor can I verify its integrity. Use at your own discretion.

SWJ0k3r commented 6 years ago

Crazy as it seems, this is still not working with the latest version of WAILA or HWYLA with the latest version of Moo Fluids for 1.10.2. I'm hoping that this is just me being stupid and someone can point me in the right direction.

I threw together a test pack with WAILA-1.7.0-B3_1.9.4 and MooFluids-1.10.2-1.7.02.12b. That is all that is in the pack. the Forge version is 12.18.3.2511.

The WAILA information shows that I am looking at a Moo Fluid Cow but it does not tell me what the fluid is. I tried all the WAILA option settings with no success.

I then opened the Moo Fluids JAR and removed the WailaRegistrar.class file. This had no effect on the display of information.

Does anyone have any ideas?

Dreghert commented 6 years ago

@TheRoBrit Hello! First of, thank you for your work on this. It is a great mod!

However, I would like to know why @ThexXTURBOXx 's file works beautifully with Hwyla for 1.10.2, and your official release still does not. I understand not supporting his build of the mod, but you could at least take a look at it, or communicate with him to figure out what he did to get it to work right.

I don't know, just seems silly to completely disregard a potential fix just because someone else came up with it.

ThexXTURBOXx commented 6 years ago

@Dreghert There is one problem: I don't even know anymore, what I changed... But he can just use my version, if he wants. This message gives him my permission. But, if you don't trust me, you can just decompile it and take a look at it yourself :)

ThexXTURBOXx commented 6 years ago

Okay... I found out what I changed... Nearly nothing... I will provide a PR with my changes today. If you want to use my fix along with Ranchable Fluid Cows, I uploaded a new version here: http://femtopedia.de/MooFluids-1.10.2-1.7.02.12b.jar And even some sources and deobfuscated things, if you want: http://femtopedia.de/MooFluids-1.10.2-1.7.02.12b-sources.jar http://femtopedia.de/MooFluids-1.10.2-1.7.02.12b-deobf.jar

SWJ0k3r commented 6 years ago

Excellent news, I will check it out!