search

RoBrit / Moo-Fluids

Mod for Minecraft that dynamically generates 'milkable' cows for various fluids
GNU General Public License v3.0
16 stars 18 forks source link

Improve automation support #68

Open JDLogic opened 6 years ago

JDLogic commented 6 years ago

It seems like the old MFR comparability mod will no longer be necessary for MC 1.11/1.12 . Therefore, the goal of this PR is to add two extra "features" from that mod into Moo Fluids itself.

  1. The ability to set a separate cooldown time when using automated machinery.
  2. Fix the client/server de-sync that occurs when a fake player interacts with a fluid cow.

Notes about the de-sync fix: The data watcher is used now as the main storage of the cooldown time since it is automatically synced to the client anytime it changes. However, we do not need to send this every tick as that would probably introduce too much packet spam. Instead, we can delay the update to every 10-20 ticks (currently set to 10) as the player should not notice if it only updates every 10-20 ticks.

I know this may not be the best way to solve this problem, so I am open to other ideas. However, I do think it is important implement some solution as de-sync can lead players to question if a machine is really milking a cow or not.

JDLogic commented 6 years ago

@TheRoBrit, I was wondering if you have had a chance to look at this yet and had any thoughts on it.

RoBrit commented 5 years ago

Hi @JDLogic,

Firstly, apologies for the late response but I've previously had this project on hiatus. I've created an 'experimental' branch for changes suggest by yourself and others, to that end if you would be able to create a new pull-request directed to the 'experimental' branch instead of the '1.12.2' branch, that would be appreciated.

Thank you.

JDLogic commented 5 years ago

No worries. I guess it is possible to change the targeted branch now, so this should hopefully be good to go now.