RoEdAl / asterisk-chan-quectel

Asterisk channel driver for Quectel and SimCOM modules
GNU General Public License v2.0
18 stars 6 forks source link

small formatting fixes #2

Closed mpmc closed 11 months ago

mpmc commented 11 months ago

As title :)

RoEdAl commented 11 months ago

has%s channel is a valid formatting pattern.

It is converted to has channel or hasn't channel. After your modifications: has "" or has "n't"!

mpmc commented 11 months ago

Ah, so it is what I originally thought!

When I first saw it, I thought "hasn't channel"/"has not channel" doesn't sound right so it must be something else, went with the safe option of assuming it meant the channel was in a mode of some sort (thinking, t, e, here). I guessed wrong, I'll change it again!

--- Done! You can cherry pick the commit as you please :)

RoEdAl commented 11 months ago

There are many many more messages with bad English.

For me instead of has/doesn't have a better solution is just channel:on/channel:off or maybe channel:attached/channel:detached.

In src/channel.c there's similar line:

ast_debug(1, "[%s] Call - idx:%d mpty:%d, [%s] -> [%s] has%s channel\n", PVT_ID(pvt), call_idx, CPVT_TEST_FLAG(cpvt, CALL_FLAG_MULTIPARTY) ? 1 : 0, call_state2str(oldstate), call_state2str(newstate), channel ? "" : "'t");

Could you correct this line too? Here with changed order:

"[%s] Call - idx:%d mpty:%d channel:%s [%s] -> [%s]\n"
RoEdAl commented 11 months ago

Fixed in 5c5f074541925325e4d441254b787016c6e65521. Thanks.