search

RoMeLaUCLA / robot-player

A wrapper library with simple, easy-to-use interfaces for controlling robots.
8 stars 2 forks source link

Bug fixing #17

Closed TMengi closed 6 years ago

TMengi commented 6 years ago

Fixes #12 - replaced the duplicate key in DXLPRO.resolution with the correct motor type.

Added a check to close DXL ports in motion_manager

Fixes #8 - used asserts to check that the number of ids matches the number of commands when setting position, velocity, etc. Throws an exception if not the same length.

Relative imports changed in motion_manager. Not sure if this breaks things for other users but it works on my end.

Removed an unused import math.pi. It was used in a commented out ifmain section in motion_manager, so I replaced those with np.pi, which is also imported.

Edited the README to reflect some changes that were made elsewhere.

Removed the default value for ports in DxlOptions.init. We said during our last meeting that it is probably best to require the user to pass a port so that we don't try to write to some unknown device by accident.

danielasun commented 6 years ago

Is this for python2 or python 3?

TMengi commented 6 years ago

These are based on the master branch, python2

danielasun commented 6 years ago

Do we need to change from using absolute imports to relative imports? Also, I think I may have encountered some small bugs in the commit. Will look at that later today.

TMengi commented 6 years ago

I'm trying to test things again and the imports seem to be failing. In the python3 and pep8 branches the imports only work for python3. Will have to read more about what changed with imports between python2 and 3

TMengi commented 6 years ago

Changed the imports from relative back to absolute. Seems to work the same on my end

danielasun commented 6 years ago

I added some unittests and checked out that everything is working on Linux.