search

RoPieee / roon-on-wine

Running Roon with Wine on Linux
MIT License
85 stars 20 forks source link

Fix "Resolution too small" error #25

Closed halfcyan closed 1 year ago

marcinulan commented 1 year ago

This fix works for me.

spockfish commented 1 year ago

Hi @halfcyan,

Can you provide some description on this PR? To me it's not entirely sure why this change is needed. If you're not setting this flag you're running Roon without the 'scalefactor' option, which is equal to running it with 'scalefactor=1' .... Or am I missing something?

Thanks

vmartell22 commented 1 year ago

I think the PR author is misinterpreting the flag - authors think it means "this is the scale factor" as opposed to what it is, "please set the scale factor"

spockfish commented 1 year ago

I've reimplemented it: it now actually is the scale factor instead of just an enable flag.

halfcyan commented 1 year ago

I think the PR author is misinterpreting the flag - authors think it means "this is the scale factor" as opposed to what it is, "please set the scale factor"

Yeah, I was misinterpreting it. I didn't really know how to read shell scripts when I wrote this so I thought it was setting the scale factor to 1x instead of telling it to set a scale factor.

I've reimplemented it: it now actually is the scale factor instead of just an enable flag.

This is a much more elegant solution, thanks.