RoPieee / roon-on-wine

Running Roon with Wine on Linux
MIT License
85 stars 20 forks source link

Update to 64-bit Roon #4

Closed duncansimpson closed 4 years ago

duncansimpson commented 5 years ago

Updated to 64-bit Roon

Updated WINE env and Roon to 64-bit. Solves:

I also tested the update to 64-bit with both .Net 4.5 and 4.72. Both work, so technically only 8794a29 is required to resolve all of the above issues and fc2f257 is not required.

pluggemi commented 5 years ago

FYI all of those items work with the 32-bit version of Roon if some extra packages are installed. These are the Archlinux package names which should be the same as Manjaro.

All of these are optional dependencies for wine and the stability is greatly improved when they are installed.

duncansimpson commented 5 years ago

Thanks @pluggemi.

It might be worth splitting the install script into one for 32-bit that has additional checks for those additional packages, and one for 64-bit. Or a single script that takes a parameter to specify which version you want.

This would give the end consumer the choice.

Also, I assume @spockfish's intent for the original script, was for it to not install wine or the other packages for you, as you may want the flexibility to do that yourself. Again this could be a parameter passed into the script as well, if you want to force install of any missing dependencies if chosen.

pluggemi commented 5 years ago

I would simplify it even further and just update the documents to mention the different packages, mainly because different distributions have different package names.

But yeah, 32 bit and 64 bit as separate scripts would be the way I would go...