Additional property and fixed positions.

RoStrap / RoStrapUI

Material Design User Interface Modules for Roblox

MIT License

14 stars 9 forks source link

Additional property and fixed positions. #36

Closed howmanysmall closed 5 years ago

howmanysmall commented 5 years ago

Added property ActionColor to change the TextColor3 of the Action button.
Fixed the positioning of the SnackbarPosition Enums.

Validark commented 5 years ago

Great idea for additions to Snackbar. A few things:

I am not sure if I am misinterpreting your image, but don't you have left and right on the improper sides?

Also I think ActionColor should probably be ActionColor3, since we have always specified that Color values are Color3 in their name. TextColor3, ImageColor3, PrimaryColor3, etc.

Validark commented 5 years ago

This too? https://github.com/RoStrap/RoStrapUI/blob/8517521482c2f118a63514205d17d4e3dd6c32a6/Snackbar.lua#L221

howmanysmall commented 5 years ago

Updated.

Validark commented 5 years ago

Great! I will test this one more time tomorrow and hopefully merge it!