Compatibility with custom vanilla maps

[Haaxor1689]

Currently Cartographer does not work correctly with custom world map data. I could create a PR that would solve this issue without affecting vanilla players, just want a "go ahead" from the author if possible. :)

[Road-block]

I'm not the original author of this mod I just found a relevant version and fixed some outstanding issues to make it working on 1.12.x vanilla client few years back.

I'm no longer playing on that client but I'm happy to accept PRs if this is still getting use.

[Haaxor1689]

I was trying to fix this issue but even though I comment out the error alert in AceLocale.prototype:GetReverseTranslation and return the original text so it shows untranslated text instead of nothing, for some reason it still logs the same error into console and I can't find where that error is logged from. Here is the only change I made.

[Road-block]

Libraries are shared code that only remains in memory once.

What that means is that if there's other addons embedding Ace/AceLocale you'd need to do the same replacement in all. The other option is to up the minor version of the library instance you edited so it's the one that remains in memory.

None of those are "proper" fixes honestly 😃

It would be best to add the missing zones to Babble-Zone and up the minor in that instead.

[Haaxor1689]

So I've added the custom zones and bumped the babble zone version. Want me to open PR or keep it separate and direct turtle wow players to my fork?

[Road-block]

Second option probably best 😃

[Road-block]

So I've added the custom zones and bumped the babble zone version. Want me to open PR or keep it separate and direct turtle wow players to my fork?

Hey I replied before taking a look at your changes. I should have clarified what I meant by upping the minor version.

You didn't need to change BabbleZone to 2.3. The minor version far as the library is concerned is this Babble-Zone-2.3.lua:L13

You don't need to rename the library folder or change the major (I know .2 based on semantic versioning concept would count as minor but it's not in this case)

You just need to up the 17779 revision number to a higher number.

[Haaxor1689]

ooh I see :D btw this will also cause other addons that use Babble-Zone load the updated version as well?

[Road-block]

That's correct