search

Roadhog360 / Et-Futurum-Requiem

[Releases] Brings the future to now!
GNU Lesser General Public License v3.0
52 stars 44 forks source link

Thaumcraft and Aether compatibility issues #288

Open OrcHunter97 opened 1 year ago

OrcHunter97 commented 1 year ago

The Thaumcraft Haste boots enchantment allows you to fly infinitely with elytra when using a rocket.

When Aether is installed, elytras are displayed incorrectly.

Amendment by Roadhog360: The former issue is currently Won't Fix due to believing Thaumcraft is likely multiplying the player's speed unconditionally although with how it's closed-source and I can't be arsed to get a decomp, I can't tell for sure what it's doing to get around it. I've effectively considered this one closed since I am under the believe there's nothing I can do on my end. Revisited and fixed The latter is where the SoS label comes in. The Aether does weird rendering things and I'm just not sure what to do. I want to fix it, I just don't know how, or if it's on my end to fix, or theirs. Someone else in my Discord is making an Aether continuation, it happens with his fork too and even he doesn't really know why it happens.

Roadhog360 commented 1 year ago

Aether compat is known and I don't know how to fix it. Will look into the Thaumcraft issue soon

P.S. please use the template next time :3

GregoriusT commented 1 year ago

I wonder if IC2 Quantum Legs have the same Issue because they just multiply speed (unsure if they have an onGround check or not). I know you can get hyperspeed with them on Ice on any non-full block such as the Path Blocks, Farmland, Slabs or Soulsand.

Roadhog360 commented 1 year ago

I tested the haste boots, yeah it seems I don't even need a rocket to gain a lot of speed and essentially fly freely. Instead of applying the speed effect properly it just speeds up the player unconditionally. I can't really do anything about mods implementing improper speed boosts. This is two issues in one, I'll let it slide so the tags are for the following issues: Won't Fix: Thaumcraft speed boots. I would need to utilize late mixins and mix into Thaumcraft to solve it which requires a Mixin library. EFR currently requires no externally downloadable libraries and for several reasons I want to keep it that way. That being said if there's a PR that can fix it without mixins, or someone knows what I can do, I will take off "won't fix" and look into it. SoS: The Aether issue. I'm just not sure where the hell this one comes from. I think other custom armor renderers get this bug too but I'm not 100% sure. I didn't write the Elytra backport so I don't understand enough to fix this one. Sorry! Any leads on what I can do to patch this one are appreciated.

Since the Aether renderer issue is left as SoS I'll leave this issue open as a whole. I'm considering the Thaumcraft one closed because I'm genuinely not even sure what I can do about that one. Sorry!

Roadhog360 commented 10 months ago

Decided to get a decomp and run code that counter-acts the haste effect. The effect is still technically running but I run code in the elytra that applies exact opposite momentum to try to counteract it. It seems to cancel out and make elytra movement normal, but please let me know if you have any issues with it.

Roadhog360 commented 10 months ago

Actually Aether is still SoS, reopening

Roadhog360 commented 10 months ago

Came up with another solution, thanks to makamys for pointing something out that allows me to mixin to Thaumcraft without any external libraries. In short, the solution above should be far more stable, please let me know if this one works.

Shahelion commented 2 months ago

What exactly is happening with the elytra rendering? I have Aether Departure and the latest update of EFR, and the elytra seem to be fine on my end.

Roadhog360 commented 2 months ago

I don't know. Maybe something he changed on his end fixed it. I think it happens with the regular Aether. Maybe some recent commits to elytra rendering managed to fix it?