Port Squid Improvements from GTNH BugTorch

[glowredman]

As suggested in https://github.com/jss2a98aj/BugTorch/pull/34

[Roadhog360]

This is improper use of Asset Director. You can register just the sound events and skip the entire thing with the dynamic resource pack. That is only needed for cave sounds. Please check how other sounds are registered and used. Additionally, the downloading of the sound should not be conditional.

[Roadhog360]

Actually, upon second review, it looks like the squid sounds are already in the mud. I'm not really sure what your code is doing there. So that entire block relating to sounds that you added can be removed because it's already in the mod.

And, of course, the ink cloud should be moved to another config because it's obviously not a sound. Let me think where it should go...

I think entities.cfg in the misc cat would do. Thank you for the contribution.

[Roadhog360]

• Reference to MCAssetVer prefix in the ink shoot sfx is missing.
• Sound is still tied to duplicate config option instead of the already existing one in the mixins config.

[Roadhog360]

Oh and the cloud option should be in catmisc because it's not an entity toggle

[Roadhog360]

Looks fine, I'll do the last few tweaks I requested. Thank you