The game crashes when using Potion arrows

Omgise commented 1 month ago

Initial Questions

[X] I have searched this issue tracker and there is nothing similar already, and this is not on the list of known issues. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
[X] I have verified that this issue occurs in a SUPPORTED environment, meaning I can reproduce this WITHOUT OptiFine, and without Bukkit+Forge server software like KCauldron, Thermos, Crucible, Mohist etc

Mod Version

etfuturum-2.6.0-master.59+0989b2b0f2

Describe the Issue

Crash when clicking Potion Arrow

https://github.com/user-attachments/assets/65eb77a8-dcdb-481f-8f7f-84572961c119

Conflicting Mods

No response

Crash Report

https://pastebin.com/wRqq9rdH

Other Details

==================== JAR FILES
+++NotEnoughVerbosity-1.7.10-0.2.jar
+Mycelium-1.5.10.jar
+unimixins-all-1.7.10-0.1.17.jar
ADFix-1.0.0.jar
akashictome-1.1.6.jar
alreadydecoratingfix-1.0a.jar
Alternate Current-1.4.1.jar
AlternativeStainedGlass-mc1.7.10-v1.0.3.jar
Anvilability-Forge-1.7.10-1.0.0.jar
AOBD-2.9.2.jar
AOBDOC-1.0.5.jar
AppleCore-3.3.2.jar
appliedenergistics2-rv3-beta-462-GTNH.jar
archaicfix-0.7.4.jar
ATOP-1.7.10-v.1.2.jar
Audino-1.1.1.jar
backhand-1.5.12.jar
BetterAchievements-0.3.0.jar
BetterHorseHud-1.7.10-1.0.jar
BetterLineBreak-1.7.10(Forge)-1.0.1.jar
BetterStorage-1.7.10-0.13.1.128.jar
BetterTooltipBox-v1.1.2.jar
BiblioCraft[v1.11.7][MC1.7.10].jar
BiblioWoods[BiomesOPlenty][v1.9].jar
BiblioWoods[ExtraBiomesXL][v1.4].jar
BiblioWoods[Natura][v1.5].jar
biggerpacketsplz-upto1.7.10-1.2.jar
BiomesOPlenty-1.7.10-2.1.0.2308-universal.jar
BowInfinityFix-1.7.10-rv0.jar
BrandonsCore-1.7.10-1.0.0.13-GTNH.jar
bugtorch-1.2.13.jar
campfirebackport-1.7.10-1.11.2+nomixin.jar
Careful+Cast+Corrector-2.0.jar
ChatCopier-1.7.10-1.1.1.jar
ChocoCraftPlus-1.7.10-4.5.9.jar
chunkapi-mc1.7.10-0.5.1.jar
ClimateControl-0.9.3-GTNH.jar
CodeChickenCore-1.3.6.jar
Coffee+Spawner-1.7.10-1.0.2.jar
CoFHCore-mc1.7.10-3.1.5-revived.jar
colorfulhealthbar-1.7.10-1.0.0.jar
CookingForBlockheads-1.3.7-GTNH.jar
CoreTweaks-1.7.10-0.3.3.2+nomixin.jar
crafttweaker-mc1.7.10-3.3.2-mega.jar
defaultworldgenerator-0.3.0.jar
DMod-1.7.10-1.0.3.5+nomixin.jar
Draconic-Evolution-1.3.8-GTNH.jar
DragonMounts-1.1.0.jar
easybreading-1.7.10-2.0.3.jar
EasyLAN-v1.5Edit-1.7.10.jar
EggParticleFix-ASM-1.0.jar
ElephantFix-Forge-1.7.10-1.0.0-mixinless.jar
endercore-0.4.6.jar
EnderIO-2.8.17.jar
enderlicious-1.1.2.jar
EnderStorage-1.6.0.jar
endlessids-mc1.7.10-1.5.4.jar
entityculling-1.6.4-mc1.7.10.jar
EntityRenderDistanceExtender-1.0c.jar
etfuturum-2.6.0-master.59+0989b2b0f2.jar
ExtrabiomesXL-3.16.8.jar
ExtraUtilities-1.2.12.2.jar
falsepatternlib-mc1.7.10-1.4.1.jar
falsetweaks-mc1.7.10-3.1.1.jar
FastLeafDecay-1.7.10-1.4.jar
flickerfix-1.7.10-v5.0.0.jar
floatingitems-1.0.jar
FlyingCullers-1.7.10-1.3.jar
ForgeCreeperHeal-1.1.1.jar
glassbreaker-1.0.0.jar
GlobalGameRules-1.0.jar
GolemTweaks-1.7.10-1.3.4.jar
gregcaves-1.2.1.jar
growthcraft-1.7.10-2.7.3-complete.jar
gtnhlib-0.5.11.jar
Hammerz-1.7.10-0.1.7.37.jar
HardcoreEnderExpansion-1.11.2-GTNH.jar
harvestcraft-1.1.10-GTNH.jar
Healer-1.2.1.jar
Heart Crystal by NukeDuck [1.7.10][1.1.1].jar
HelpFixer-1.3.0.jar
hodgepodge-2.5.70.jar
HorizontalBackport-mc1.7.10-v1.0.0.jar
immersive-snow-1.7.10-1.0b.jar
ImmersiveEngineering-mc1.7.10-0.7.11.jar
immersiveintegration-0.6.8.jar
industrialcraft-2-2.2.828a-experimental.jar
IngameIME-1.7.10-2.0.10.jar
InputFix-1.7.10-v6.jar
inventorytweaks-1.6.2.jar
IronChest-6.0.86.jar
JABBA-1.4.6.jar
JarFinder.jar
KeyboardWizard-Legacy-Forge-1.7.10-1.0.0.jar
kingdomregions-5.6.jar
LanHostSkinReFixed-1.7.10-rv1.jar
legacyfixes-1.8.1.jar
liteloader-1.7.10.jar
lumi-mc1.7.10-1.0.0.jar
Mantle-0.4.1.jar
matmos-1.7.10-36.0.1+nomixin.jar
Mekanism-Community-Edition-1.7.10-9.10.36-ALL.jar
Metallurgy-1.7.10-4.0.9.148.jar
MetallurgyCore-1.7.10-4.0.5.30.jar
MineFactoryReloaded-2.8.1-pilz2.jar
MineTweakerRecipeMaker-1.7.10-1.1.1.jar
mobspawningfix-1.0a.jar
MoCreatures-Legacy-1.1.jar
ModernKeyBinding-Forge-1.7.10-2.1.0-mixinless.jar
modernsplash-1.7.10-1.2.1-d88da6a.dirty.jar
ModTweaker2-0.11.0.jar
MoreEnchantments-1.7.10-1.3.2.1.jar
MoreFurnaces-1.3.9-MC1.7.10.jar
MouseTweaks-2.4.17-GTNH.jar
MrCrayfish'sFurniture-3.4.8.jar
Natura-2.7.3.jar
NaturalAbsorption-1.2.1.1.jar
naturescompass-1.4.3-GTNH.jar
Neat-1.0.3.jar
necrotempus-1.3.2.jar
neodymium-mc1.7.10-0.3.3-unofficial.jar
netherlicious-3.2.8.jar
NetherOres-[1.7.10]2.3.2B1-25.jar
netherportalfix-1.3.0.jar
Neutron-Forge-1.7.10-0.1.1-hotfix.jar
NoMoreRecipeConflict-1.7.10-0.3.2.jar
NotEnoughItems-2.6.30-GTNH.jar
NotEnoughPets-1.7.10-2.3.6.jar
notfine-6b90dc5.jar
noworldgen5you-1.0.jar
omniconfig-1.0.1-mc1.7.10.jar
overloadedarmorbar-1.1.0.jar
Pam's Harvest the Nether 1.7.10a.jar
paniclecraft-1.7.10-2.7.2.0.jar
PatPatPat-Forge-1.7.10-1.0.0.jar
ProgressiveAutomation-1.7.10-1.6.35.jar
QuickTrashCan-1.7.10-1.0.0.jar
RandomRandomness-2.0.0.jar
RandomThings-2.5.3.jar
rawinput-1.7.10-v1.4.2.jar
ReducedMusicDelay-1.7.10.jar
RTG-1.1.3-GTNH.jar
SafeKeyString-Forge-1.7.10-1.0.0-mixinless.jar
Satchels-1.7.10-1.0.7.jar
serializationisbad-1.5.2.jar
ShoulderSurfing-1.7.10-2.4.1.jar
Simple F3.jar
simpleskinbackport-f67fa88-master+f67fa8890c-dirty.jar
SmartTreeFelling-1.7.10-1.1.0.jar
SmoothFont-1.7.10-1.15.3.jar
soundphysics-1.1.1.jar
squidless-1.7.10-0.6.1.jar
tbetwixt-1.0.0.jar
ThermalExpansion-[1.7.10]4.1.5-248.jar
ThermalFoundation-[1.7.10]1.2.6-118.jar
threadsafetyfixes-2.2.1.jar
TileEntityResetFix-1.0.1-noreq.jar
torohealth-1.1.0.jar
Translocator-1.2.1.jar
tumbleweed-1.7.10-0.3.jar
TwilightForest-2.6.34.jar
VendingMachinesRevamped_1.1.0_1.7.10.jar
VillageNames-1.7.10-4.4.12.jar
VillagerMetaFix-0.4.jar
vineclimber-3.0.0.jar
Waila-1.8.1.jar
WAILAPlugins-0.5.1.jar
Wawla-1.3.0-GTNH.jar
waystones-1.7.10-v1.0.1a-LE.jar
weaponmod-forge-1.7.10-1.22.2.jar
wild_netherwart-1.7.10-v2.1.jar
Windows Keyboard Fixes-forge-1.7-1.0.1.jar
WirelessCraftingTerminal-1.11.2.jar
WorldSelectionAdvanced-1.7.10-8.jar
Ztones-2.3.1-GTNH.jar
zume-1.1.2.jar
[1.6.1-1.12.2]HighDPI-Fix-1.4.0.jar
[1.7.10]ArmorStatusHUD-client-1.28.jar
[1.7.10]StatusEffectHUD-client-1.27.jar
1.7.10\BaublesExpanded-2.1.4.jar
1.7.10\CodeChickenLib-1.3.0.jar
1.7.10\ForgeMultipart-1.5.0.jar
1.7.10\[1.7.10]bspkrsCore-universal-6.16.jar
ic2\EJML-core-0.26.jar

==================== OTHER FILES
mod_PotionColorizer_1.1.0_mc1.7.10.litemod
PresenceFootsteps_r5c_Unofficial__1.7.10.litemod
presencefootsteps\userconfig.cfg

Roadhog360 commented 1 month ago

Cannot reproduce

GregoriusT commented 1 month ago

theories:

the tipped arrow in question has null NBT data and that does something.

OR, what is more likely:

the tipped arrow might have one of the few duplicate potion metas (8194), and you did not assign an Icon to them, yes some potions have TWO metas assigned to them for some reason, and pretty sure Harming is one of those dual-potions. So depending on how you brew the potion, you get a harming potion with different meta out of it

Omgise commented 1 month ago

Cannot reproduce

I found that the problem was caused by the Potion Colorizer LiteLoader mod, as I used the mod's function to disable the glow effect of potion items, which conflicted with the EFR potion arrow.

Omgise commented 1 month ago

After deleting the Potion Colorizer mod, everything returned to normal.

Omgise commented 1 month ago

This is PotionColorizer download address: https://github.com/EasyMFnE/PotionColorizer/

Roadhog360 commented 1 month ago

It's not immediately obvious to me why this mod breaks

Roadhog360 commented 1 month ago

My guess it must be changing the icon somewhere. There is this huge black box of reflection in the mod that it is hard to tell what it is actually doing. But if it's making assumptions about what the iicon is that doesn't work with modded potions that'd cause it. Our tipped arrows are in compliance with the same metas regular potions are.

Does this mod break lingering potions too?

Omgise commented 1 month ago

Does this mod break lingering potions too?

no, it only destroys the potion arrow

Roadhog360 commented 1 month ago

These are some interesting tricks in reflection I've never seen before. Hey Greg, is this reflection effectively overwriting code in the methods? That does seem pretty cool, although I can't find out why it breaks at the moment.

GregoriusT commented 1 month ago

Edit -- ignore that, i tested my theory and it doesnt crash --

Roadhog360 / Et-Futurum-Requiem