search

RoadieHQ / helm-charts

Helm charts for RoadieHQ tools
https://charts.roadie.io
Apache License 2.0
2 stars 9 forks source link

Use Issuer instead of ClusterIssuer #49

Closed MPV closed 3 years ago

MPV commented 3 years ago

Hi, I just noticed that when deploying the backstage chart, it wanted to deploy a ClusterIssuer, which seems too much. I think it might be enough with just an Issuer (which thus acts only in that namespace where this chart has been deployed). Especially given that it hasn't been named/prefixed for just backstage, it may surprise others when they get a new cluster-global issuer that any services in the cluster can use.

See their docs for details: https://cert-manager.io/docs/concepts/issuer/

MPV commented 3 years ago

Semi-related thought from reading these files (based on own needs/experience): not everyone might use nginx as their ingress class, so it might make sense to have that configurable?

martina-if commented 3 years ago

Hi @MVP, thank you for the feedback and the PR, we appreciate it and those comments are very valid.

However, this chart is no longer officially supported for the community. We mainly use this internally and we are planning to make it a private repo, but we can't do that just yet.

The official chart for Backstage lives in: https://github.com/backstage/backstage/tree/master/contrib/chart/backstage

I will be happy to help review the same changes applied to that repo instead.

Sorry for the inconvenience, we will make this more clear in the README file.