RoadieHQ / helm-charts

Helm charts for RoadieHQ tools
https://charts.roadie.io
Apache License 2.0
2 stars 9 forks source link

adds workflow for deploying sample-service to dev0 cluster #68

Closed punkle closed 3 years ago

punkle commented 3 years ago

ch3494

shortcut-integration[bot] commented 3 years ago

This pull request has been linked to Clubhouse Story #3494: Deploy sample service to dev0.

nicolasarnold12321 commented 3 years ago

Should we create a helmrelease k8s object like with roadie-backstage?

punkle commented 3 years ago

@nicolasarnold12321 I like the idea, but I think it adds a bit of complexity. I dont think we need the type of auto recovery and resiliance for this service. What do you think?

nicolasarnold12321 commented 3 years ago

@nicolasarnold12321 I like the idea, but I think it adds a bit of complexity. I dont think we need the type of auto recovery and resiliance for this service. What do you think?

We could even just deploy it manually instead of having automation if you prefer. Whenever we make changes to chart in the future we just bump the chart version. I just don't really like the idea of github creating resources that's all.

nicolasarnold12321 commented 3 years ago

If you're happy with that I don't mind approving!

Might be worth adding a change to the sample-service repo so that it is triggered.

punkle commented 3 years ago

ok cool. done. Ive deployed it manually. Ill close this.