Some fixes on migrating the Argocd FE plugin

RoadieHQ / roadie-backstage-plugins

All Backstage plugins created by Roadie.

https://roadie.io

Apache License 2.0

280 stars 403 forks source link

Some fixes on migrating the Argocd FE plugin #1616

Closed nuritizra closed 1 month ago

nuritizra commented 2 months ago

Added some fixes while the docs were updated to use blueprints. Also, we don't need the page extension as we only use cards. In addition, I updated the README file.

:heavy_check_mark: Checklist

[ ] Added tests for new functionality and regression tests for bug fixes
[x] Added changeset (run yarn changeset in the root)
[ ] Screenshots of before and after attached (for UI changes)
[x] Added or updated documentation (if applicable)

nuritizra commented 2 months ago

@punkle @karlhaworth appreciate your review!

Xantier commented 2 months ago

Could we at the same time modify the naming convention in exporting the plugin. It looks very unprofessional to be exporting alpha functionality and I'm not sure if that's worth doing. Is the frontend system finalized at this stage?

Rugvip commented 2 months ago

@Xantier the frontend system is not stable yet and there will be more breaking changes. Whether you want to have it exported via /alpha or not is up to you tbh, but you'd ofc need to make sure you forward any breaking changes from the core APIs that affect the external API of your package.

Xantier commented 2 months ago

Hmm, thanks @Rugvip. @nuritizra would it make sense to hold off on this until the frontend system gets into a stabler state. Currently this addition looks to be just introducing a maintenance burden.

github-actions[bot] commented 1 month ago

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

Rugvip commented 1 month ago

@Xantier these changes are just helping out with the migrations from https://backstage.io/docs/frontend-system/architecture/migrations#130. We want to push for adoption of the new frontend system by plugins already now, because it's hard to move to and encourage adoption in apps until we have decent support from plugins.

Xantier commented 1 month ago

Thanks @Rugvip, wouldn't it be better to wait for few adopters who are using the frontend system on their instances before we start adding these in. It is quite a burden to keep these up to date with alpha version of the framework since there are changes expected on the underlying interfaces.

Would you be maintaining this migration @nuritizra ?