Roald87 / TcBlack

Opnionated code formatter for TwinCAT.
MIT License
103 stars 11 forks source link

Remove assembly signing #69

Closed Roald87 closed 3 years ago

Roald87 commented 3 years ago

Github secrets are not available to forked repos. That's why the piplines of the PR's failed from others than mine.

Singing would only be necessary in case of publishing a release. So, it should be possible to remove the required signature when it goes into the pipeline for only builds and tests.

Roald87 commented 3 years ago

https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-options/security

Roald87 commented 3 years ago

Asked a question on stackoverflow.

Roald87 commented 3 years ago

Bounties the StackOverflow question. If there is no answer, I'll remove the singing. It causes too much trouble.

Roald87 commented 3 years ago

See also https://github.com/Roald87/TcBlack/pull/65

Roald87 commented 3 years ago

Removing the singing. This is causing so many headaches and frankly I do not understand the advantages.