Hashtag-based link syntax does not support international characters

Roam-Research / issues

Roam Research - A note-taking tool for networked thought.

https://roamresearch.com/

303 stars 7 forks source link

Hashtag-based link syntax does not support international characters #3

Closed teodorlu closed 4 years ago

teodorlu commented 4 years ago

Describe the bug

Hashtag-based link syntax does not support international characters.

German, Russtian and emoticon-based (by Ralf Westphal):

Norwegian (by me):

To Reproduce

Steps to reproduce the behavior:

Try to create a hashtag-link where the link contains international characters
Watch the link cut off before the first international character

Additional context

From Slack: https://roamresearch.slack.com/archives/CN5MK4D2M/p1582801515145800

teodorlu commented 4 years ago

Workaround: use a hashtag and brackets: #[[eksempel/høy-viktighet]]

Suggested by Conor on Slack to the report.

teodorlu commented 4 years ago

Another advantage of the hashtag and bracket syntax is that it supports spaces. This is really great.

Personally, I consider this a solved problem, then. I am able to write any link, and it shows the tag without grabbing attention.

I'm still choosing not to close this issue, because I think it makes sense to have proper i18n support in a heavily text-based product. Perhaps more relevant when we get closer to a non-beta release.

panterarocks49 commented 4 years ago

We just deployed a fix for international characters in tags, can you verify it's working for you now? (might have to reload page first)

teodorlu commented 4 years ago

Looks good. Thanks!

I consider this issue resolved.