Roam-Research / issues

Roam Research - A note-taking tool for networked thought.
https://roamresearch.com/
304 stars 7 forks source link

JSON import fails if page title includes a [[reference]] to a page that already exists in your graph #579

Closed TristanH closed 3 years ago

TristanH commented 3 years ago

Describe the bug JSON import fails if page title includes a [[reference]] to a page that already exists in your graph. This can be especially problematic for backups, as it's conceivable this bug would prevent you from importing a previously exported version of your graph.

To Reproduce

  1. Make sure you have a page titled inbox in your roam graph
  2. Import a file to roam with this content:

[{"title": "[[inbox]]/this won't import", "children": [{"string": "hello"}]}]

  1. The import will fail with error message ", even though that page title is valid and the page does not exist in roam.
TristanH commented 3 years ago

Noticed this also happens with content inside of an imported file.

If you have a block with the text [[[[inbox]]]]in your json file and the page inbox already exists in your Roam database, the import will also fail.

Bardia95 commented 3 years ago

Was able to reproduce the first issue but not "If you have a block with the text [[[[inbox]]]]in your json file and the page inbox already exists in your Roam database, the import will also fail."

Could you record a screen recording of it failing?

TristanH commented 3 years ago

@Bardia95 thanks for the quick turnaround!

Here's the screenrecording:

https://www.loom.com/share/53068cabca1d4e46bd5a1cab71f2e34a

And here's the file I used:

[{"title": "this won't import either", "children": [{"string": "hello [[[[inbox]] inside other ref]]"}]}]

filipesilva commented 3 years ago

@TristanH I tried following these steps but I can't get the error message. Do you still see this happening?

TristanH commented 3 years ago

Looks like you guys fixed it at some point since Oct! :) Happy to close.