Roam-Research / issues

Roam Research - A note-taking tool for networked thought.
https://roamresearch.com/
304 stars 6 forks source link

Alias/link doesn't work if the link contains parentheses #630

Open benjamindv36 opened 3 years ago

benjamindv36 commented 3 years ago

Describe the bug

When trying to create a link to a web address containing parentheses (https://en.wikipedia.org/wiki/Electron_(software_framework) in this case), it doesn't turn into a link.

Image: roam alias bug

To Reproduce

Steps to reproduce the behavior:

  1. Create a link containing parentheses (such as Electron)
  2. Roam will not recognize it as a link

System Information:

wfischer42 commented 3 years ago

Ran into the same problem. If you need something to make it work until it's fixed, you can manually URL encode the parentheses with %28 and %29.

[Electron](https://en.wikipedia.org/wiki/Electron_%28software_framework%29)
benjamindv36 commented 3 years ago

Great! Thank you for the fix.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Tuesday 1 December 2020 13:54, William Fischer notifications@github.com wrote:

Ran into the same problem. If you need something to make it work until it's fixed, you can manually URL encode the parentheses with %28 and %29.

Electron

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

keenanpayne commented 3 years ago

Thanks for documenting this problem; I just ran into the same issue with an article on Wikipedia.

8E9E5E59-E769-4525-9052-3B771C9B5B73 0DEB5B73-4C42-46EC-9005-C0C368C1AAA2

@wfischer42 Thank you for the quick fix! Looking forward to when these URLs are properly encoded in Roam.

Soleone commented 3 years ago

Thanks for creating this issue! This is actually causing a bunch of work for me:

Typically I have headlines for topics like:

[thing](url)

  • fact 1
  • fact 2

But whenever the URL contains parentheses (and yes, it's mostly wikipedia for me as well right now) I instead do the following structure to make it more quickly readable:

thing

  • wikipedia (i collapse this to make the whole thing more concise)
    • url
  • fact 1
  • fact 2