search

Roam-Research / issues

Roam Research - A note-taking tool for networked thought.
https://roamresearch.com/
304 stars 6 forks source link

Dragging gifs, images, etc. directly from webpage into Roam does not work on Chrome #647

Open sooheon opened 3 years ago

sooheon commented 3 years ago

Dragging an image or gif from a webpage into the Safari version of Roam uploads the file to firebase. This does not work for Chrome or Electron.

Steps to reproduce the behavior:

  1. Find an image or GIF online, say from this page: https://github.com/wwang2/torchmd
  2. Drag the gif into Roam. You should see the placement bar appear.
  3. Release the drag. In Safari this results in the gif uploaded to FB and then placed in Roam. In Chrome nothing happens.

System Information:

Additional context

Same thing happens with electron wrappers like Nativifier or Uniter.

ShaDubya commented 3 years ago

If it's helpful to add, Drag/drop gifs does not work for me in Safari. When I drag a gif (either the one linked above or this one) to a page in Safari, the placement bar does appear but on releasing the mouse, the placement bar does not disappear nor does the gif paste.

System Information:

Roam version: 0.7.8-6a388a5e
Device: Macbook Air 11"
OS: macOS Catalina 10.15.7
Browser: Safari

https://user-images.githubusercontent.com/76816038/103413149-4e657d00-4b46-11eb-8096-66f8f25ec957.mov

sooheon commented 3 years ago

I think the issue is not due to Roam, but MacOS Security & Privacy features. I've added Chrome and my roam electron app to the list of apps with "Full Disk Access", and now drag and drop works. Normally when an app requests disk access and is refused there's a popup, but I guess roam doesn't know how to handle it.

edit: drag and drop images/gifs works with files from my filesystem, but not directly from a web page as in your example.