YouTube embed doesn't work

Roam-Research / issues

Roam Research - A note-taking tool for networked thought.

https://roamresearch.com/

304 stars 7 forks source link

YouTube embed doesn't work #675

Closed annieeby closed 3 years ago

annieeby commented 3 years ago

Describe the bug

You seem to have added a new video feature. It doesn't work.

To Reproduce

Insert a YouTube link see grey and white play icon appear click icon see embedded video appear click to play video see error appear

System Information:

Roam version: 0.7.8-345999d7
Device: computer
OS: Windows 10
Browser: Chrome

Additional context

Bardia95 commented 3 years ago

Can you send me the exact YouTube link you are trying to view so I can check it against our regex, I've yet to run into this problem, and the youtu.be/8Or link does not seem to be a valid link.

annieeby commented 3 years ago

You're right. It's working. I thought I checked it with other videos, but maybe didn't; anyway, everything's working now. Check out this idea though: https://github.com/Roam-Research/issues/issues/649 :)