Roam-Research / issues

Roam Research - A note-taking tool for networked thought.
https://roamresearch.com/
304 stars 7 forks source link

Google Search Featured Snippets URL causing Roam to Freeze #695

Open UncleVesimir opened 3 years ago

UncleVesimir commented 3 years ago

Describe the bug

"Google Search Featured Snippets" are a feature of Google Search that allows for highlighting answers on linked AMP articles.

Link to Example of Google Featured Snippets

Using the URL from a Google Featured Snippet as the destination URL for a Roam link causes Roam to freeze.

To Reproduce

Steps to reproduce the behavior:

  1. Create a link in Roam i.e. link

  2. Insert the following as the destination URL for that link https://9to5google.com/2018/12/30/google-search-featured-snippets-amp-highlight/#:~:text=With%20Feature%20Snippets%2C%20users%20can,where%20the%20full%20answer%20resides.

  3. Press Return/Enter or click on the page to "create the link" in Roam

  4. See bug

    Loom Video Showing Bug

System Information:

Additional context

It appears Google Search adds the code below onto the end of the destination URL in the Google Search Featured Snippet. I assume this is done to indicate to Chrome what section of text to highlight to the user on the page they click through to. `

:~:text=With%20Feature%20Snippets%2C%20users%20can,where%20the%20full%20answer%20resides.

`

Removing this code, and recreating a Roam link with a URL that doesn't contain this code stopped Roam from freezing.