search

RoamJS / query-builder

https://roamjs.com/extensions/query-builder
MIT License
20 stars 5 forks source link

Not all blueprintjs icons are supported #129

Open mdroidian opened 1 year ago

mdroidian commented 1 year ago

Related to https://github.com/RoamJS/query-builder/pull/128

When adding to the docs, we want to point to https://blueprintjs.com/docs/#icons/icons-list or even https://blueprintjs.com/docs/versions/2/#icons to let users know the total icon options available for action:{action}:{icon}, but not all icons render:

image

image image

Version issue? From qb package-lock.json

image

Yet, icon is listed in node_modules\@blueprintjs\icons\lib\esm\generated\iconNames.d.ts

image

dvargas92495 commented 1 year ago

We support this version of blueprint bc that's what Roam is using. This allows us to use the Blueprintjs available at window. instead of bundling our own