search

RoamJS / query-builder

https://roamjs.com/extensions/query-builder
MIT License
20 stars 5 forks source link

Relation Context in Discourse Context is not working #199

Open mdroidian opened 8 months ago

mdroidian commented 8 months ago

https://oasis-lab.gitbook.io/roamresearch-discourse-graph-extension/guides/exploring-your-discourse-graph/discourse-context#show-the-context-of-each-relation

image

Reported by Ekuboh in slack

mdroidian commented 7 months ago

The Context column via Discourse Context was commented out here https://github.com/RoamJS/query-builder/pull/98, then removed fully here https://github.com/RoamJS/query-builder/pull/123

It looks like this functionality was somewhat replaced in Query Drawer and Query Blocks via actions (where action:context:icon loads the full page).

But was the ExtraColumnRow for Discourse Context also supported somewhere else?

Discourse Context image

I'm leaning towards "no" because it still exists in DiscourseContext.tsx but has no references to it. @dvargas92495 thoughts?

image https://github.com/RoamJS/query-builder/blob/292f950d3cb3ffe76482c1681a9f57d10800cfec/src/components/DiscourseContext.tsx#L33

dvargas92495 commented 7 months ago

no it wasn't - I thought it would but that was the only use case and you're right as far as the modern way to go about this