search

RoamingLost / Chimera.Extensions.Logging.Log4Net

ASP.NET Core / .NET Core logging extension for log4net
MIT License
1 stars 2 forks source link

Scopes are not implemented #3

Open slawomir-brzezinski-at-interxion opened 6 years ago

slawomir-brzezinski-at-interxion commented 6 years ago

They are not implemented, so the extra log information is thrown away, while it is rather useful. E.g. ASP.NET Core provides all the data in bold:

RequestId:0HKV9C49II9CK RequestPath:/api/some-resource/0 => MyApp.Controllers.SomeResourceController.GetById (MyApp) => Hello world!

Implementation: Log4Net actually provides the Stacks functionality which is actually the equivalent (it even returns an IDisposable) and, with a little bit of plumbing, it should be possible to put it there.

I should be able to provide a pull request soon.

slawomir-brzezinski-at-interxion commented 6 years ago

PR now open. Please let me know if you need anything.