search

RoanH / KeysPerSecond

A keys-per-second meter & counter. Written for osu! but should work for other rhythm games too.
https://osu.ppy.sh/forum/t/552405/
GNU General Public License v3.0
346 stars 28 forks source link

Command operation bug #100

Closed capticka closed 2 weeks ago

capticka commented 5 months ago

Hello, again. I am telling you that there is an error in KeyPerSecond. There is a command here, but it doesn't work well. I reset the total, but the stats are reset, and I reset the stats again, but the total is reset. Also, even if you press Ctrl + R for both total initialization and stat initialization, only one of the total or stats will be reset, and no matter how many times you press it again, it will not be reset. That was a bit long. Please fix it. V8.9

RoanH commented 5 months ago

Hello, I feel like there are multiple issues in this report:

  1. There is a command here, but it doesn't work well. The reset totals command Ctrl+I is perhaps named a bit misleading since it predates the total panel, this command only resets the total number of hits for each key panel (so not the total panel). I may rename it for the next release.
  2. I reset the total, but the stats are reset Stats refers to the aggregate panels, so MAX/AVG/KPS/TOT/LST, I can't reproduce these being reset by the reset totals command.
  3. and I reset the stats again, but the total is reset. The TOT panel is one of the stat panels together with MAX/AVG/KPS/LST, so this is intentional.
  4. Also, even if you press Ctrl + R for both total initialization and stat initialization, only one of the total or stats will be reset, and no matter how many times you press it again, it will not be reset. I can't reproduce this, all of the key panels and AVG/MAX/KPS/LST/TOT get reset to 0 if I run Ctrl+R.

Please let me know if I misunderstood something or if anything is unclear.

capticka commented 5 months ago

Why do I reset only the panels such as KPS, MAX, AVG, TOT, etc. even if I set the Reset stats and Reset totals commands with Ctrl + R?

RoanH commented 5 months ago

Ctrl+R is intended to reload the entire configuration, it resetting the counts is just a side effect. If you have automatic stats saving on exit and/or stats loading on launch enabled, then it won't even reset the stats at all since they'll be restored when you reload the config.

capticka commented 5 months ago

By any chance, can't this program execute two commands with the same command?

RoanH commented 5 months ago

Ah, that's an interesting use case. Setting the same key combination for different commands will indeed cause one of them to not execute, specifically, the precedence order is reset stats > exit > reset totals > hide > pause > reload. I suppose that since the key combinations are configurable now it would be better allow them to be bound more than once, I'll pick that up for the next release.

capticka commented 5 months ago

Oh, I think that was the problem. Thank you.

RoanH commented 2 weeks ago

Fixed this now for the next release (v8.10).