search

RoanH / KeysPerSecond

A keys-per-second meter & counter. Written for osu! but should work for other rhythm games too.
https://osu.ppy.sh/forum/t/552405/
GNU General Public License v3.0
346 stars 28 forks source link

FIX: Overlay mode isn't applied via config file. #41

Closed SaeGon-Heo closed 3 years ago

SaeGon-Heo commented 3 years ago

If I drag & drop config.kpsconf3 file on KeysPerSecond-v8.4.exe to run it with saved config which Overlay mode is true, Overlay mode option is enabled but doesn't applied. And this PR may fix this.

RoanH commented 3 years ago

Hey, thank you for the bug report and pull request. Nice job finding this bug. Your fix works properly, but the underlying issue is a bit more involved (honestly configuration files should be handled better, I'll get around to that someday). The stats saving is actually suffering from the exact same issue, for some reason I decided to manually manage the state of a few things even though I have a subroutine called reconfigure to do exactly that... And it seems like the manual managing did not work out for the overlay option and stats saving.

I'll push a few commits of my own to fix stats saving and then I'll merge this if you're fine with the changes I've made.

SaeGon-Heo commented 3 years ago

Looks cool. I didn't noticed reconfigure() function does at all :) You may go ahead with that. Thanks to patch a bug!

RoanH commented 3 years ago

Awesome, thanks for the contribution.