RoanH / KeysPerSecond

A keys-per-second meter & counter. Written for osu! but should work for other rhythm games too.
https://osu.ppy.sh/forum/t/552405/
GNU General Public License v3.0
342 stars 28 forks source link

Request: Ability to change the moving average window #79

Open riskygames opened 1 year ago

riskygames commented 1 year ago

Hi there! Many thanks for making this project. I'm trying to use it to diagnose and demonstrate an issue with my keyboard intermittently cutting out. I realised after setting up the program for maximum precision / time resolution that all keystrokes will always be averaged out over the (1 second?) window of the moving average of the graph. It'd be great if this could be customised - a 100ms moving average would be low enough for me. Also some might prefer a slower & smoother updating graph. Keep up the good work!

RoanH commented 1 year ago

Hey! That's an interesting proposal. I'm honestly not entirely sure yet how much sense this makes as this would essentially be changing the changing the name from KeysPerSecond to KeysPerXms. I know some games prefer to use APM instead so for those cases it might make sense though.

Implementing the feature itself is probably not too much work, but I would like to have some proper way to justify its inclusion. I'm also not entirely sure if this would actually make it possible to detect a keyboard cutting out. For that you'd technically just want to see if the panel for the key you pressed lights up or not, or if a panel flickers without you releasing the key. Panel updates are in real time, so the only thing limiting that is your monitor refresh rate.

As for the graph, if you want it to update slower you have to increase the backlog, potentially by a lot if you set a very high update rate.