Remove `-Wmodule-import-in-extern-c` warnings

RoaringBitmap / CRoaring

Roaring bitmaps in C (and C++), with SIMD (AVX2, AVX-512 and NEON) optimizations: used by Apache Doris, ClickHouse, and StarRocks

http://roaringbitmap.org/

Other

1.57k stars 268 forks source link

Remove `-Wmodule-import-in-extern-c` warnings #654

Closed rockwotj closed 2 months ago

rockwotj commented 2 months ago

When using clang modules (not C++ modules) #including stuff within extern "C" blocks causes warnings. Remove said warnings by moving the #include. See this StackOverflow question for an idea of what the warning looks like.

Before submitting this PR, run tools/clang-format.sh on your changes. See the "Contributing" section in the README for details.

lemire commented 2 months ago

Let us run the tests. If they pass, we shall merge and release.

rockwotj commented 2 months ago

Ping - looks like they passed. Thank you again for your time here!