Port `get_index` and the bitset functions

RoaringBitmap / croaring-rs

Rust FFI wrapper for CRoaring

Apache License 2.0

157 stars 43 forks source link

Port `get_index` and the bitset functions #107

Closed Dr-Emann closed 1 year ago

Dr-Emann commented 1 year ago

Port roaring_bitmap_get_index as Bitmap::position (the name was chosen to match with Iterator::position)
Update bindgen to add bindings for bitset_* methods/types/variables
Port bitset_* functions, and roaring_bitmap_to_bitset as Bitmap::to_bitset
Update to version 1.3.0 of CRoaring

Because of the version update, this will clash with #105 and #106

saulius commented 1 year ago

Really struggling to find proper time to review larger amounts of code lately, but generally it looks great to me! Thanks one more time for the contribution.

On that note, @Dr-Emann, you made some great contributions over the last years to croaring-rs. Would you be willing to maintain the project together? I have an intention to transfer it over to RoaringBitmap Github org, if @lemire is up for it.

andreas commented 1 year ago

I'm currently advocating for the croaring-crate to be supported by AWS RDS for Postgres via plrust (blog post). Having croaring-rs adopted by the RoaringBitmap org would be a big benefit in that regard, so selfishly I'd love to see that happen 😊

Dr-Emann commented 1 year ago

I'd certainly be willing to help maintain the project, and I also personally think it would make sense to end up under the RoaringBitmap org.