RoastBeefer00 / rmatrix

rmatrix
https://crates.io/crates/rjmatrix
10 stars 1 forks source link

Big terminal not recognized properly #8

Open Rijaja opened 2 weeks ago

Rijaja commented 2 weeks ago

This might be a problem with ratatui because I couldn't find anything weird in your code.

Something goes wrong when reading the size of the terminal if it's really big. For example with a 143 character tall terminal, the count is off starting at 459 characters wide, and gets misread as 459×142 instead. It gets worse the bigger the terminal. The biggest i could get my terminal is 509×143 and the program thought is was 482×135.

System info:

Not a big problem though, i just maxed out the size to see how fast your implementation is. This isn't a realistic scenario.

RoastBeefer00 commented 2 weeks ago

@Rijaja What terminal emulator do you use and what resolution is your monitor? How are you determining those numbers?

Rijaja commented 2 weeks ago

I'm using Konsole 24.08.2 on a 2560x1600 display

RoastBeefer00 commented 2 weeks ago

I think I'm able to recreate the issue. Thanks, I'll look into it

RoastBeefer00 commented 2 weeks ago

"Bottom", another TUI written in Ratatui seems to have the exact same problem. The size doesn't keep up at the exact same point as my program. I'm thinking this is a ratatui problem and will open an issue on their page.

You did inspire me to improve the resize functionality though, so thank you