No error shown when leaving Full name empty, but submit button left disabled

RoastSoftware / roaster

Automatically grades your code!

https://roast.software

GNU General Public License v3.0

5 stars 1 forks source link

No error shown when leaving Full name empty, but submit button left disabled #210

Open wstrm opened 5 years ago

wstrm commented 5 years ago

According to the API spec. the fullname field is not required, but this isn't throughly tested (I believe most stuff on the frontend will just display an empty full name, should maybe display the username at some places, and not anything in the search results).

So the quickfix in the mean time would be to just require the full name in the frontend, and display an error if empty, and then in the future fix the views.

I believe this one can be on hold.

wstrm commented 5 years ago

@Hjortsberg, I'll mark this as partially fixed.

wstrm commented 5 years ago

Partially fixed in #218