Closed michael-rubel closed 2 months ago
Hey @Ocramius
Can we do anything to allow symfony/console ^7.0 without breaking the CI, or would you rather address the newly reported issues?
@michael-rubel I suggest trying a very minimal composer update symfony/console
to reduce composer.lock
changes.
Also, let's please bump the range: don't widen it.
Yeah, I tried that minimal update at first but psalm and some other packages want to upgrade before it installs v7.
Would suggest helping with #732 first then :)
It looks like the bot already tried the update in https://github.com/Roave/BackwardCompatibilityCheck/pull/753
The https://github.com/Roave/BackwardCompatibilityCheck/pull/732 is a bit stale. It probably makes sense to bump the lock to the latest versions and then address the issues, because for example psalm is required at least from 5.16 as it's the version when they added support for Symfony 7 (ref: https://github.com/vimeo/psalm/releases/tag/5.16.0).
That was already attempted in #730: needs work :)
Hell, I'll see if I have spare time for this.
The project needs some spring gardening work, basically :D
@Ocramius It seems that everything passes on PHP 8.2+
@Ocramius Ping 👋
@michael-rubel I need to let this sit for a bit: currently stuck with pre-easter-vacation-deadlines-everywhere. Do ping again if stuck after Easter!
@Ocramius how's it going? 😁
Only one failure, and it's not really part of the public API of this package anyway: nice!
Error: The number of required arguments for Symfony\Component\Console\Command\Command#setApplication() increased from 0 to 1
Let's :ship: this
About
Symfony 7 is required for seamless usage with Laravel 11.