Roave / BackwardCompatibilityCheck

:ab: Tool to compare two revisions of a class API to check for BC breaks
MIT License
568 stars 59 forks source link

Spring gardening: Symfony 7 support #762

Closed michael-rubel closed 2 months ago

michael-rubel commented 3 months ago

About

Symfony 7 is required for seamless usage with Laravel 11.


michael-rubel commented 3 months ago

Hey @Ocramius

Can we do anything to allow symfony/console ^7.0 without breaking the CI, or would you rather address the newly reported issues?

Ocramius commented 3 months ago

@michael-rubel I suggest trying a very minimal composer update symfony/console to reduce composer.lock changes.

Also, let's please bump the range: don't widen it.

michael-rubel commented 3 months ago

Yeah, I tried that minimal update at first but psalm and some other packages want to upgrade before it installs v7.

Ocramius commented 3 months ago

Would suggest helping with #732 first then :)

michael-rubel commented 3 months ago

It looks like the bot already tried the update in https://github.com/Roave/BackwardCompatibilityCheck/pull/753

The https://github.com/Roave/BackwardCompatibilityCheck/pull/732 is a bit stale. It probably makes sense to bump the lock to the latest versions and then address the issues, because for example psalm is required at least from 5.16 as it's the version when they added support for Symfony 7 (ref: https://github.com/vimeo/psalm/releases/tag/5.16.0).

Ocramius commented 3 months ago

That was already attempted in #730: needs work :)

michael-rubel commented 3 months ago

Hell, I'll see if I have spare time for this.

Ocramius commented 3 months ago

The project needs some spring gardening work, basically :D

michael-rubel commented 3 months ago

@Ocramius It seems that everything passes on PHP 8.2+

michael-rubel commented 3 months ago

@Ocramius Ping 👋

Ocramius commented 3 months ago

@michael-rubel I need to let this sit for a bit: currently stuck with pre-easter-vacation-deadlines-everywhere. Do ping again if stuck after Easter!

michael-rubel commented 2 months ago

@Ocramius how's it going? 😁

Ocramius commented 2 months ago

Only one failure, and it's not really part of the public API of this package anyway: nice!

Error: The number of required arguments for Symfony\Component\Console\Command\Command#setApplication() increased from 0 to 1

Let's :ship: this