Roave / BetterReflection

:crystal_ball: Better Reflection is a reflection API that aims to improve and provide more features than PHP's built-in reflection API.
MIT License
1.19k stars 131 forks source link

Update dependency nikic/php-parser to v5 - autoclosed #1387

Closed renovate[bot] closed 8 months ago

renovate[bot] commented 10 months ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
nikic/php-parser ^4.18.0 -> ^5.0.2 age adoption passing confidence

Release Notes

nikic/PHP-Parser (nikic/php-parser) ### [`v5.0.2`](https://togithub.com/nikic/PHP-Parser/blob/HEAD/CHANGELOG.md#Version-502-2024-03-05) [Compare Source](https://togithub.com/nikic/PHP-Parser/compare/v5.0.1...v5.0.2) ##### Fixed - Fix handling of indentation on next line after opening PHP tag in formatting-preserving pretty printer. ##### Changed - Avoid cyclic references in `Parser` objects. This means that no longer used parser objects are immediately destroyed now, instead of requiring cycle GC. - Update `PhpVersion::getNewestSupported()` to report PHP 8.3 instead of PHP 8.2. ### [`v5.0.1`](https://togithub.com/nikic/PHP-Parser/blob/HEAD/CHANGELOG.md#Version-501-2024-02-21) [Compare Source](https://togithub.com/nikic/PHP-Parser/compare/v5.0.0...v5.0.1) ##### Changed - Added check to detect use of PHP-Parser with libraries that define `T_*` compatibility tokens with incorrect type (such as string instead of int). This would lead to `TypeError`s down the line. Now an `Error` will be thrown early to indicate the problem. ### [`v5.0.0`](https://togithub.com/nikic/PHP-Parser/blob/HEAD/CHANGELOG.md#Version-500-2024-01-07) [Compare Source](https://togithub.com/nikic/PHP-Parser/compare/v4.18.0...v5.0.0) See UPGRADE-5.0 for detailed migration instructions. ##### Fixed - Fixed parent class of `PropertyItem` and `UseItem`.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



Read more about the use of Renovate Bot within ocramius/* projects.

Ocramius commented 9 months ago

If we want to move this forward from our end, it's probably feasible via extracting test dependencies to their own directory.

That becomes a pain with the test setup though, so unsure about the chicken-egg situation, for now.

Will sleep over it a few times :thinking:

tacman commented 9 months ago

It's not a big deal, but it'd be nice if you could support version 5.

composer why nikic/php-parser 
phpunit/php-code-coverage 9.2.30  requires nikic/php-parser (^4.18 || ^5.0) 
roave/better-reflection   6.23.0  requires nikic/php-parser (^4.18.0)       
sebastian/complexity      2.0.3   requires nikic/php-parser (^4.18 || ^5.0) 
sebastian/lines-of-code   1.0.4   requires nikic/php-parser (^4.18 || ^5.0) 
symfony/maker-bundle      v1.53.0 requires nikic/php-parser (^4.18|^5.0)    
tacman commented 9 months ago

While I don't understand rennovate, it's working in 'dev' for me now, thanks!

composer why nikic/php-parser 
phpunit/php-code-coverage 9.2.30                            requires nikic/php-parser (^4.18 || ^5.0) 
roave/better-reflection   dev-renovate/nikic-php-parser-5.x requires nikic/php-parser (^5.0.0)        
sebastian/complexity      2.0.3                             requires nikic/php-parser (^4.18 || ^5.0) 
sebastian/lines-of-code   1.0.4                             requires nikic/php-parser (^4.18 || ^5.0) 
symfony/maker-bundle      v1.54.0                           requires nikic/php-parser (^4.18|^5.0)    
Ocramius commented 9 months ago

In theory, this is fixable via https://github.com/Roave/infection-static-analysis-plugin/pull/489 (and some additional testing), but I'm stuck over there due to tests failing for a missing coverage driver.

What is confusing me is why the mainline branch and the PR have different build environments (within the same day): https://github.com/Roave/infection-static-analysis-plugin/pull/489#issuecomment-1934754666