Add `getStartLine` and `getEndLine` to `BetterReflection\Reflection\Adapter\ReflectionEnumUnitCase`

Roave / BetterReflection

:crystal_ball: Better Reflection is a reflection API that aims to improve and provide more features than PHP's built-in reflection API.

MIT License

1.19k stars 131 forks source link

Closed ruudk closed 4 months ago

ruudk commented 4 months ago

👋 Hi all, thanks for creating this amazing library.

When reflecting an enum, for each case, I want to know where it's defined.

This is possible on BetterReflection\Reflection\ReflectionEnumCase but not on BetterReflection\Reflection\Adapter\ReflectionEnumUnitCase.

Before I create the PR to address this, I want to know if this was an oversight? Or done on purpose.

Ocramius commented 4 months ago

@ruudk the adapters only mirror the API of ext-reflection, so we don't add any more API to them than what is declared in upstream.