New feature: support images in markdown

Roave / DocbookTool

:books: Docbook Tool for static documentation generation from Markdown files

52 stars 4 forks source link

New feature: support images in markdown #251

Closed asgrim closed 2 years ago

asgrim commented 2 years ago

Fixes #248

Example of rendered HTML (in Friefox)

example-html-2

Example of rendered PDF (Linux in Evince)

Screenshot from 2022-09-22 11-26-04

asgrim commented 2 years ago

Conlfuence writer regex needs updating actually (\Roave\DocbookTool\Writer\ConfluenceWriter::extractImagesFromContent is restricted to the generated diagrams currently)

Ocramius commented 2 years ago

Aaaaaand I messed up -.-

https://github.com/Roave/DocbookTool/pull/251#issuecomment-1254850600

Holding off a release.

asgrim commented 2 years ago

As discussed with @asgrim, SVGs and such won't work yet, but that's fine for now.

SVG issue created in #252 for a future improvement :+1: