search

Roave / DocbookTool

:books: Docbook Tool for static documentation generation from Markdown files
52 stars 4 forks source link

If file is empty, determineTitleFromContent will crash #272

Closed asgrim closed 1 year ago

asgrim commented 1 year ago

If the markdown file is completely empty, the determineTitleFromContent crashes, because strtok returns false presumably.

#0 5.983 [2022-10-07T15:43:58.149851+00:00] cli.INFO: Writing HTML output to /docs-package/index.html [] []
#0 5.998 PHP Fatal error:  Uncaught TypeError: str_starts_with(): Argument #1 ($haystack) must be of type string, bool given in /app/src/DocbookPage.php:70
#0 5.998 Stack trace:
#0 5.998 #0 /app/src/DocbookPage.php(70): str_starts_with()
#0 5.998 #1 /app/src/DocbookPage.php(83): Roave\DocbookTool\DocbookPage->determineTitleFromContent()
#0 5.998 #2 /app/vendor/twig/twig/src/Extension/CoreExtension.php(1607): Roave\DocbookTool\DocbookPage->title()
#0 5.998 #3 /app/vendor/twig/twig/src/Environment.php(358) : eval()'d code(226): twig_get_attribute()
#0 5.998 #4 /app/vendor/twig/twig/src/Template.php(394): __TwigTemplate_3767b10960c12aea038deadddc8f0951->doDisplay()
#0 5.998 #5 /app/vendor/twig/twig/src/Template.php(367): Twig\Template->displayWithErrorHandling()
#0 5.998 #6 /app/vendor/twig/twig/src/Template.php(379): Twig\Template->display()
#0 5.998 #7 /app/vendor/twig/twig/src/TemplateWrapper.php(40): Twig\Template->render()
#0 5.998 #8 /app/vendor/twig/twig/src/Environment.php(277): Twig\TemplateWrapper->render()
Ocramius commented 1 year ago

Handled in #278