Switch to PHPUnit 10 attributes instead of PHPDoc

Roave / DocbookTool

:books: Docbook Tool for static documentation generation from Markdown files

52 stars 4 forks source link

Switch to PHPUnit 10 attributes instead of PHPDoc #369

Closed herndlm closed 7 months ago

herndlm commented 7 months ago

Small thing. Not sure in which direction you want to go, but since PHPDoc is deprecated with PHPUnit 11 and I'm adding attribute usage in my other PR, I thought it might be a good idea to keep this stuff consistent.

herndlm commented 7 months ago

ok guess, psalm can't deal with that. I'm not a psalm user and this is not important. Will close again silently :)

looks like this is being tracked in https://github.com/psalm/psalm-plugin-phpunit/issues/131

Ocramius commented 7 months ago

TBH, patch is valuable, but indeed needs upstream changes first.

lotyp commented 4 months ago

Upstream patch is here: https://github.com/psalm/psalm-plugin-phpunit/pull/145 But currently only for #[Test] attribute