search

Roave / EmailTemplates

BSD 3-Clause "New" or "Revised" License
14 stars 8 forks source link

PHP 7.1 feature #11

Open peter279k opened 6 years ago

peter279k commented 6 years ago

After checking the Travis build, it seems that the function arguments are serious for checking the function argument counter. Here is the exception ,message snippet during executing the PHPUnit test:

EmailTemplatesTest\InputFilter\TemplateInputFilterTest::testValidationOfEachProperty with data set #0 ('updateParameters', true, null, true)
ArgumentCountError: Too few arguments to function Roave\EmailTemplates\Validator\CanRenderValidator::__construct(), 0 passed in /home/lee/EmailTemplates/vendor/zendframework/zend-servicemanager/src/AbstractPluginManager.php on line 291 and exactly 1 expected

Please fix this. Thanks.

Ocramius commented 6 years ago

Could you elaborate with an example?

On 7 Feb 2018 20:21, "peter279k" notifications@github.com wrote:

After checking the Travis build, it seems that the function arguments are serious for checking the function arguments. Here is the code snippet

EmailTemplatesTest\InputFilter\TemplateInputFilterTest::testValidationOfEachProperty with data set #0 ('updateParameters', true, null, true) ArgumentCountError: Too few arguments to function Roave\EmailTemplates\Validator\CanRenderValidator::__construct(), 0 passed in /home/lee/EmailTemplates/vendor/zendframework/zend-servicemanager/src/AbstractPluginManager.php on line 291 and exactly 1 expected

Please fix this. Thanks.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Roave/EmailTemplates/issues/11, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJakDgN5SHG43hIwut9tny-pRsshaPkks5tSffKgaJpZM4R9QFl .

macnibblet commented 6 years ago

Reading the Travis-ci logs, it looks like it's installing Zend framework components that are no longer supporting the old style of factories. I'll update the factories and tag a new master based on the latest components tomorrow.